>+ static NS_HIDDEN_(int) PR_CALLBACK RealTimeSpellCallback(const char* pref, void* closure) >Index: layout/forms/nsTextControlFrame.h Why so much space? One blank line between functions should be about right. This function doesn't return an nsresult. Under what conditions would |frame| be null? If it can't be, assert instead of checking. >+ nsTextControlFrame* frame = NS_REINTERPRET_CAST(nsTextControlFrame*, context) This should assert that |pref| is what you expect. >nsTextControlFrame::RealTimeSpellCallback(const char* pref, void* context) Add a pref to control it, and set it in your config or something. This is -1705,7 +1707,12 // we working on Camino decided to allow inline spellcheck for single line fields >+ nsTextControlFrame::RealTimeSpellCallback, this)
>+ nsContentUtils::UnregisterPrefCallback(PREF_DEFAULT_SPELLCHECK, > nsTextControlFrame::Destroy(nsPresContext* aPresContext) >Index: layout/forms/nsTextControlFrame.cpp I can't review this part please get someone familiar with spell-checker to do so.
>Index: extensions/spellcheck/src/mozInlineSpellChecker.h >Index: extensions/spellcheck/src/mozEnglishWordUtils.cpp p puts in the function names, -8 gives more context. Isn't it the whole ideaīehind Camino: leverage Mac OS X functionalities to better fit into the mac user experience ?Ĭomment on attachment 208498 įor future reference, this would be a _lot_ easier to review if you use better diff options. This is certainly possible to reuse in a web browser if Safari team got it right. Words, etc.) (As was initially requested for that bug.) (Same dictionary, same dialog box for spell check settings, same rendering of erroneous Words and what event should trigger spell checking.)įor Camino, we should aim at getting as close as possible to how Safari works, that is rely on Mac OS X (With discussion over how to render the erroneous But why shouldīug 58612 sounds like a complete implementation. I would expect Firefox spellchecker to depend on bug 58612, as it is crossplatform. If you want this to be fixed, go vote for bug 58612. Until that core bug is fixed, there won't > The masses are awaiting spelcheking in Camino. For all that is sacred in this world, can someone.anyone, please work on this?
0 kommentar(er)
